Skip to content

fix logic for setting alternate background in mod list items #9528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

grahamlangford
Copy link
Collaborator

What does this PR do?

  • Fixes bug with the logic to set the alternate background in ModListItem

Demo

  • image

For more information on our expectations for the PR process, see the
code review principles doc

@grahamlangford grahamlangford self-assigned this Nov 15, 2024
Copy link

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@twschiller twschiller added the bug Something isn't working label Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.76%. Comparing base (8318d74) to head (afee199).
Report is 513 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9528      +/-   ##
==========================================
+ Coverage   74.24%   75.76%   +1.52%     
==========================================
  Files        1332     1427      +95     
  Lines       40817    43058    +2241     
  Branches     7634     7924     +290     
==========================================
+ Hits        30306    32625    +2319     
+ Misses      10511    10433      -78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grahamlangford grahamlangford enabled auto-merge (squash) November 15, 2024 15:10
@grahamlangford grahamlangford merged commit 45e518a into main Nov 15, 2024
24 checks passed
@grahamlangford grahamlangford deleted the fix-mod-list-item-active-hover branch November 15, 2024 15:16
Copy link

Playwright test results

passed  152 passed
flaky  2 flaky
skipped  2 skipped

Details

report  Open report ↗︎
stats  156 tests across 51 suites
duration  11 minutes, 13 seconds
commit  afee199
info  For more information on how to debug and view this report, see our readme

Flaky tests

msedge › tests/extensionConsole/activation.spec.ts › can activate a mod via url
chrome › tests/pageEditor/saveMod.spec.ts › shows error notification when updating a public mod without incrementing the version

Skipped tests

chrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options
msedge › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants