feat: add option to disable single finger drag #520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, there is no option to disable dragging when one finger is used only.
This is useful because a lot of apps require to being able to scroll the page in a normal manner.
Having some random canvas-drawing that catches the event and prevents the normal behavior can be quite annoying.
In this case, 2 finger drags are the way to go.
Thats why I added an option "disableTouch" that prevents the drag when only one finger is used.
Maybe I should rename it to "disableOneFingerDrag".
Let me know what you think!
PS: This is only a half solution because pixi still catches all pointer events and prevents scrolling a normal page. Any pointers on how to fix this are welcome