Skip to content

fix: cache-buster hash is always 6 characters #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CyberDex wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: cache-buster hash is always 6 characters #188

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc1e2f9
fix: pad crc32 hex in getHash so the hash is always 6 characters
CyberDex Nov 10, 2026
4471550
test: update manifest hashes renamed by the getHash padding fix
CyberDex Nov 10, 2026
a4832da
test: update spine atlas hashes renamed by the getHash padding fix
CyberDex Nov 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/assetpack/src/core/utils/getHash.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ export function getHash(input: string | Buffer): string {
input = fs.readFileSync(input);
}

const checksumHex = crc32.crc32(input).toString(16);
// Pad to 8 hex digits: Buffer.from drops the last digit of an odd-length hex string.
const checksumHex = crc32.crc32(input).toString(16).padStart(8, '0');

return Buffer.from(checksumHex, 'hex').toString('base64url');
}
22 changes: 22 additions & 0 deletions packages/assetpack/test/core/Utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@ import { describe, expect, it } from 'vitest';
import { AssetPack } from '../../src/core/AssetPack.js';
import { extractTagsFromFileName } from '../../src/core/utils/extractTagsFromFileName.js';
import { generateCacheName } from '../../src/core/utils/generateCacheName.js';
import { getHash } from '../../src/core/utils/getHash.js';
import { createAssetPipe, createFolder, getCacheDir, getInputDir, getOutputDir } from '../utils/index.js';
import crc32 from '@node-rs/crc32';

import type { Asset } from '../../src/core/Asset.js';
import type { AssetPipe } from '../../src/core/index.js';
Expand Down Expand Up @@ -208,4 +210,24 @@ describe('Utils', () => {

expect(cacheName3).toEqual('ab900fa81d7121ea46bd2eafe9e826633c1c48a0');
});

it('should always return a 6 character hash', () => {
const findInput = (accept: (crc: number) => boolean) => {
for (let i = 0; ; i++) {
const buffer = Buffer.from(`asset-${i}`);

if (accept(crc32.crc32(buffer))) return buffer;
}
};

// crc32 values with 1, 2 and 3 leading zero hex digits
for (const limit of [0x10000000, 0x1000000, 0x100000]) {
expect(getHash(findInput((crc) => crc < limit))).toMatch(/^[\w-]{6}$/);
}

// hashes without a leading zero are unchanged
const buffer = findInput((crc) => crc >= 0x10000000);

expect(getHash(buffer)).toBe(Buffer.from(crc32.crc32(buffer).toString(16), 'hex').toString('base64url'));
});
});
Loading