Improve the @pixi/runner developer experience #10243
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The current implementation of the `runner' package is not always usable with classes and can cause bugs due to overly complicated generics.
I removed default values of
Runner
generics, fixed improper use ofunknown
type and made types smaller to make errors more readable.Also i found a bug(?) in BufferSystem caused by lack of strict checks that the object contains a callback function. I didn't add these checks myself so as not to change the APIs of this class too much, but this change may help us avoid similar problems in the future.
Let me know if it's OK to add them, I'll include them in this PR.
Instances problem
before
now
Explicit generics
before
now
Pre-Merge Checklist
npm run lint
)npm run test
)