Update Design Tokens, Add CSS Variables Tests, and Introduce Custom CSS Variables for @charcoal-ui/react
#604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naporin0624
force-pushed
the
naporitan/replace-token1
branch
from
e868021
to
3a1cc80
Compare
naporin0624
temporarily deployed
to
preview-channel
GitHub Actions
Inactive
|
Visit the preview URL for this PR (updated for commit d41b3b7): https://pixiv-charcoal-web--pr604-naporitan-replace-to-f16s63p3.web.app (expires Wed, 09 Oct 2024 09:01:01 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 314b26d3adca98a761c7e4d9922ebb206ff024a0 |
|
Size Change: +234 B (0%) Total Size: 26 MB
ℹ️ View Unchanged
|
naporin0624
temporarily deployed
to
preview-channel
GitHub Actions
Inactive
naporin0624
temporarily deployed
to
preview-channel
GitHub Actions
Inactive
naporin0624
temporarily deployed
to
preview-channel
GitHub Actions
Inactive
naporin0624
temporarily deployed
to
preview-channel
GitHub Actions
Inactive
naporin0624
temporarily deployed
to
preview-channel
GitHub Actions
Inactive
naporin0624
temporarily deployed
to
preview-channel
GitHub Actions
Inactive
…an/replace-token1
naporin0624
temporarily deployed
to
preview-channel
GitHub Actions
Inactive
naporin0624
commented
Jul 25, 2024
naporin0624
commented
Jul 25, 2024
naporin0624
temporarily deployed
to
preview-channel
GitHub Actions
Inactive
naporin0624
temporarily deployed
to
preview-channel
GitHub Actions
Inactive
yue4u
reviewed
Sep 17, 2024
yue4u
reviewed
Sep 17, 2024
| @@ -1,39 +1,40 @@ | |||
| .charcoal-text-area-root { | |||
| --charcoal-text-area-rows: ; | |||
There was a problem hiding this comment.
完全なる手癖で内部で定義される variables を root で定義したいっていう挙動をしてました
There was a problem hiding this comment.
思い出しました。新トークンに移行するにあたり作った test file の関係で variables を事前定義したかったからでした。
packages/theme/package.json
Outdated
Comment on lines
14
to
21
| "./dark.css": { | ||
| "require": "./dist/css/_variables_dark.css", | ||
| "import": "./dist/css/_variables_dark.css" | ||
| }, | ||
| "./light.css": { | ||
| "require": "./dist/css/_variables_light.css", | ||
| "import": "./dist/css/_variables_light.css" | ||
| } |
There was a problem hiding this comment.
IMO: renamingしないほうが使いやすそうな気がします
There was a problem hiding this comment.
d41b3b7 rename しないようにしました
There was a problem hiding this comment.
別件ですが_variablesのcssに --になっているケースがあるようで欲しいかもしれないです
There was a problem hiding this comment.
あ～ test の部分この可能性を全く考慮されてないので条件付け加えます.....
yue4u
reviewed
Sep 17, 2024
Comment on lines
15
to
18
| while ((match = usedVariablePattern.exec(cssContent)) !== null) { | ||
| matches.push(match[1]) | ||
| } | ||
| return matches |
yue4u
reviewed
Sep 17, 2024
| @@ -1,3 +1,5 @@ | |||
| import './index.css' | |||
There was a problem hiding this comment.
これだとlayeredと切り替えないので、token含めてユーザー側でimportしたほうが良さそうな気がします
There was a problem hiding this comment.
build 後だと index.css に分離されるのでユーザー側 import にります！
yue4u
reviewed
Sep 17, 2024
Comment on lines
+27
to
+33
| for (const file of variableFiles) { | ||
| const content = await readFile(file, 'utf-8') | ||
| const variables = extractVariables(content) | ||
| for (const variable of variables) { | ||
| variablesSet.add(variable) | ||
| } | ||
| } |
There was a problem hiding this comment.
There was a problem hiding this comment.
const files = import.meta.glob("../../theme/src/css/*.css`, {
import: "default",
eager: true,
as: "raw"
});
/**
* stdout | packages/react/src/css-variables.test.tsx
* {
* '../../theme/src/css/_variables_dark.css': '',
* '../../theme/src/css/_variables_light.css': ''
* }
* */無が得られる(調査あんまりしてない)ので何か知っていたら教えてほしいです...:pray:
|
別件、_variables_light.cssの |
naporin0624
temporarily deployed
to
preview-channel
GitHub Actions
Inactive
naporin0624
temporarily deployed
to
preview-channel
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
やったこと
@charcoal-ui/react.動作確認環境
チェックリスト
不要なチェック項目は消して構いません