feat: typescript v5 #1406
feat: typescript v5 #1406
Conversation
| @@ -1,7 +1,9 @@ | |||
| import * as THREE from 'three'; | |||
|
|
|||
| const encodingColorSpaceMap: Record<any, '' | 'srgb'> = { | |||
| // eslint-disable-next-line @typescript-eslint/naming-convention | |||
There was a problem hiding this comment.
It's possible to avoid this comment via tweaking eslint config but that needs some regex magic. I think it's easier to disable here.
| @@ -53,6 +53,10 @@ | |||
| { | |||
| "selector": "enumMember", | |||
| "format": ["PascalCase"] | |||
| }, | |||
There was a problem hiding this comment.
for THREE, V1MToonSchema, V0VRM ...
| "ts-node": "^10.9.2", | ||
| "tslib": "^2.6.2", | ||
| "typedoc": "^0.25.13", | ||
| "typescript": "^5.4.5" |
There was a problem hiding this comment.
I think three-vrm still does not require users to use typescript v5 yet after this PR.
There was a problem hiding this comment.
PR to remove downlevel-dts #1302 . I think that is still valid and can be merged either before or after this PR.
| "cross-env": "^7.0.2", | ||
| "downlevel-dts": "^0.11.0", | ||
| "eslint": "^7.12.1", | ||
| "eslint": "8", |
There was a problem hiding this comment.
is the version specifier intentional? eslint seems to bump minor frequently so it might be reasonable enough to do this though
There was a problem hiding this comment.
ESlint v9 is out but not very well supported by plugins for now. Basically this means latest v8 and I don't think there'll be many v8 releases from now on.
There was a problem hiding this comment.
sure! if it's intentional it's fine
|
merging into |
Upgrade to typescript v5 and bump related deps (eslint, jest, typedoc, ...etc)