Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add new shadowIntensity value to mtoon shader (2) #1441

Merged
merged 2 commits into from
Jul 19, 2024
Merged

fix: Add new shadowIntensity value to mtoon shader (2) #1441

merged 2 commits into from
Jul 19, 2024

Conversation

0b5vr
Copy link
Contributor

@0b5vr 0b5vr commented Jul 19, 2024

Redo of #1431 , preserving @ashconnell 's commit

Three 166 introduces a new light.shadowIntensity value (mrdoob/three.js#28588) which breaks three-vrm as the shader won't compile.

This PR updates the MToon fragment shader to use the new value.

My commit adds pre-r166 compatibility.

@0b5vr 0b5vr added the bug Something isn't working label Jul 19, 2024
@0b5vr 0b5vr added this to the next milestone Jul 19, 2024
@0b5vr 0b5vr self-assigned this Jul 19, 2024
@0b5vr 0b5vr mentioned this pull request Jul 19, 2024
Closed
@0b5vr 0b5vr merged commit 657b397 into dev Jul 19, 2024
6 checks passed
@0b5vr 0b5vr deleted the shadow-intensity branch July 19, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@0b5vr 0b5vr

Labels
bug Something isn't working
Projects
None yet
Milestone
v2.1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@0b5vr @ashconnell