fix: change VRMSpringBoneManager circular dependency error to warning #1462
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0b5vr
reviewed
Aug 9, 2024
| @@ -7,6 +7,8 @@ import { traverseChildrenUntilConditionMet } from './utils/traverseChildrenUntil | |||
|
|
|||
| export class VRMSpringBoneManager { | |||
| private _joints = new Set<VRMSpringBoneJoint>(); | |||
| private _hasWarnedCircularDependency = false; | |||
There was a problem hiding this comment.
warn once per VRMSpringBoneManager (= a model). Good
yue4u
deleted the
fix/change-VRMSpringBoneManager-circular-dependency-error-to-warning
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change VRMSpringBoneManager circular dependency error to warning.
After this PR three-vrm will try the best to render models contain this issue instead of error out.