PRESIDECMS-3243 many to one admin view - #1748
Open
seakchiew wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the admin datamanager is getting the data from versioned table, some of the deleted record via cascade delete / set null from relationship table is not reflected properly in the version table, hence a quick check if object exists before generating the link would help to hide link with not found / deleted record.
Note
Low Risk
Low risk: adds a guard to avoid rendering admin links/labels when the related record no longer exists, which should only change display behavior for stale FK values.
Overview
Prevents the Many-to-One admin renderer (
ManyToOne.cfc) from generating a related-record link/label when the target record is missing.adminViewnow checkspresideObjectService.dataExists()(and that the related object name is non-empty) before callingevent.buildAdminLink()andrenderLabel(), avoiding broken links for deleted/cascaded relationships.Written by Cursor Bugbot for commit e2e6f58. This will update automatically on new commits. Configure here.