Skip to content

PageTypesServiceTest.test05: assert allowedChildTypes membership, not struct iteration order #1804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexskinner wants to merge 1 commit into
base: stable
Choose a base branch
from
+6 −1
Open

PageTypesServiceTest.test05: assert allowedChildTypes membership, not struct iteration order #1804

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion tests/unit/api/pageTypes/PageTypesServiceTest.cfc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,12 @@ component output="false" extends="tests.resources.HelperObjects.PresideTestCase"
super.assertEquals( "page-types.casestudy.index" , pageTypeBean.getViewlet() );
super.assertEquals( "page-types.casestudy.add" , pageTypeBean.getAddForm() );
super.assertEquals( "page-types.casestudy.edit" , pageTypeBean.getEditForm() );
super.assertEquals( "casestudy,blog,event,some_page_type,page,teammember", pageTypeBean.getAllowedChildTypes() );
// A `*` allowedChildTypes resolves to every site-tree page type; the ORDER is just
// the iteration order of the registered-page-types struct, which is an engine
// implementation detail (Lucee's default struct is HashMap/hash-ordered, others are
// insertion-ordered). Assert MEMBERSHIP, not incidental order — as test02 already does.
super.assertEquals( ListSort( "casestudy,blog,event,some_page_type,page,teammember", "textnocase" )
, ListSort( pageTypeBean.getAllowedChildTypes(), "textnocase" ) );
super.assertEquals( "*" , pageTypeBean.getAllowedParentTypes() );
}

Expand Down
Loading