PRESIDECMS-3327: add relative between time period types - #1817
Open
jjannek wants to merge 1 commit into
Open
Conversation
Allow rolling windows that do not end at now (e.g. 48 hours ago to 24 hours ago, or 24 hours from now to 48 hours from now) without freezing absolute dates. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pastOnly/futureOnly. Absolutebetweenis unchanged. Inverted offsets are swapped sofromis always earlier thanto.measure2 = 0means until/from now.Fixes the gap where dashboard compares and rules-engine filters could not express a rolling window that does not end at now (today vs yesterday was the only calendar workaround).
Ticket: PRESIDECMS-3327
Test plan
RulesEngineTimePeriodServiceTest(48h–24h, missing measure2, swapped offsets, invalid unit, future 24h–48h, omitted unit2)pastOnly: relative past appears, relative future does not