First version of allowing a video to play on the background of the lo… - #1
First version of allowing a video to play on the background of the lo…#1wsg-media wants to merge 3 commits into
Conversation
|
|
||
| public string function backgroundVideo( event, rc, prc, args={} ) { | ||
| var bgVideo = getSystemSetting( "admin-login-security", "video_background" ); | ||
|
|
There was a problem hiding this comment.
Should put in a check here, rather than in the view, to see if the bgVideo is defined, and if not just return an empty string.
| </cfscript> | ||
|
|
||
| <cfif args.bgVideo.len()> | ||
| <div class="vimeo-wrapper"> |
There was a problem hiding this comment.
vimeo-wrapper is a bit specific, if it could also be a YouTube video. Maybe something more generic like login-video-wrapper
| <form i18nBaseUri="system-config.admin-login-security:" > | ||
| <tab id="display" sortorder="30"> | ||
| <fieldset id="background" sortorder="10"> | ||
| <field sortorder="10" name="video_background" control="textinput" required="false" /> |
There was a problem hiding this comment.
Maybe set this as a url input?
|
|
||
| .login-layout { | ||
|
|
||
| .vimeo-wrapper { |
There was a problem hiding this comment.
See comments in the view on naming of this class
| width: 100vw; | ||
| height: 56.25vw; | ||
| min-height: 100vh; | ||
| min-width: 177.77vh; |
There was a problem hiding this comment.
This is all locked to the video being 16:9 ratio.
Woiuld recommend trying the aspect-ratio CSS property: https://caniuse.com/mdn-css_properties_aspect-ratio
So, lose the width and height, have min-width and min-height as 100vw and 100vh, and then set the aspect ratio directly in the HTML of the iframe, so it could be pulled from a setting alongside the video URL.
2 participants
…gin screen