ADMINTHEME-124 Select the v2 admin layout without aborting the request so postLayoutRender fires - #41
Merged
DominicWatson merged 2 commits intoAug 21, 2026
Conversation
DominicWatson
deleted the
feature-ADMINTHEME-124_fix-postlayoutrender-abort
branch
August 21, 2026 18:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the v2 admin layout aborting the request before
postLayoutRendercan fire. The v2 admin and admin-login layouts selected their v2 chrome with an include followed by an abort; because the abort ends the request from insiderenderLayout(), ColdBox never announced thepostLayoutRenderinterception point, so no interceptor or extension could alter the rendered admin page. This replaces the include-and-abort with anif/elsesorenderLayout()returns normally andpostLayoutRenderfires, for both the v1 and v2 layouts. Rendered output is unchanged for both versions; only the request lifecycle changes.