ADMINTHEME-126 Responsive top navigation - #43
Open
pixl8-jg wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the admin top level navigation responsive, so the header no longer wraps onto a second line when there is not enough room for every item. The space available to the nav changes for reasons unrelated to viewport width - a wider site picker, or controls added to the header at runtime - so none of this is driven by media queries. The toolbar is now a single non-wrapping flex row in which
#topLevelNavis the only flexible child, so its width tracks the leftover space whatever changes, and oneResizeObserveron it covers every case.