Add composite index api_queue_poll for data_api_queue - #97
Open
bhorisk wants to merge 1 commit into
Open
Conversation
Dequeue queries filter on subscriber, queue_name, and namespace and order by order_number. Previously MariaDB could use index_merge plus filesort; the composite (subscriber, queue_name, namespace, order_number) aligns with DataApiQueueService.getNextQueuedItems and getQueueCount. Deploying requires Preside DB sync to create the new physical index. Made-with: Cursor
|
Brian Horisk seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce timeouts on API when queue gets large.
New composite index (subscriber, queue_name, namespace, order_number) aligns with DataApiQueueService.getNextQueuedItems and getQueueCount.
(related to DATAAPI-47)
Note
Low Risk
Schema/index-only change with minimal behavior impact; primary risk is migration/index creation time and any unintended query-plan changes under load.
Overview
Improves performance of polling large
data_api_queuetables by adding a new composite indexapi_queue_pollacrosssubscriber,queue_name,namespace, andorder_number.This is implemented by updating the
indexesmetadata on the relevant properties inpreside-objects/data_api_queue.cfcto define the composite index ordering while keeping existing single-column indexes.Reviewed by Cursor Bugbot for commit 138691d. Bugbot is set up for automated code reviews on this repo. Configure here.