Detect SAML request rule expression - #17
Open
choontat-pixl8 wants to merge 3 commits into
Open
Conversation
DominicWatson
requested changes
Oct 4, 2023
| * @serviceProviders.multiple true | ||
| */ | ||
| private boolean function evaluateExpression( event, rc, prc, boolean _is=true, string serviceProviders="" ){ | ||
| if ( !isStruct( rc.samlRequest ?: "" ) ) { |
Contributor
There was a problem hiding this comment.
This looks fantastic. Great work making this concise. However, it is missing taking the _is into account. I suggest refactoring to something along the lines of:
var isSamlLoginRequest = false;
if ( IsStruct( rc.samlRequest ?: "" ) ) {
if ( !Len( arguments.serviceProviders ) || ListFindNoCase( ... ) ) {
isSamlLoginRequest = true;
}
}
return isSamlLoginRequest == arguments._is;
Contributor
|
Fab, thanks @choontat-pixl8 - merging for QA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.