Skip to content

fix: memoize updateEditorLanguage and fix useEffect dependency #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
narutamaaurum wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: memoize updateEditorLanguage and fix useEffect dependency #491

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions modules/playground/components/playground-editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
"use client";

import { EDITOR_CONFIG } from "@/lib/constants/config";
import { useRef, useEffect, useState } from "react";
import { useRef, useEffect, useState, useCallback } from "react";
import Editor, { type Monaco } from "@monaco-editor/react";
import type { editor as MonacoEditor } from "monaco-editor";
import {
Expand Down Expand Up @@ -253,7 +253,7 @@ const PlaygroundEditor = ({
);
};

const updateEditorLanguage = () => {
const updateEditorLanguage = useCallback(() => {
if (!activeFile || !monacoRef.current || !editorRef.current) return;
const model = editorRef.current.getModel();
if (!model) return;
Expand All @@ -264,12 +264,11 @@ const PlaygroundEditor = ({
} catch (error) {
console.warn("Failed to set editor language:", error);
}
};
}, [activeFile]);

useEffect(() => {
updateEditorLanguage();
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [activeFile]);
}, [updateEditorLanguage]);

// Bind Yjs to Monaco
useEffect(() => {
Expand Down