Skip to content

fix(editor): sanitize user name before CSS interpolation in Yjs awareness styles #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Xenon010101 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(editor): sanitize user name before CSS interpolation in Yjs awareness styles #516

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6f97f9
fix(editor): sanitize user name before CSS interpolation in Yjs aware…
Xenon010101 Jul 21, 2026
f190bb8
fix(editor): add type guards and hex color validation to sanitization
Xenon010101 Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions modules/playground/components/playground-editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,18 @@ const PlaygroundEditor = ({
.padEnd(6, "0")
: "#30bced";

const sanitizeForCss = (value: unknown): string =>
typeof value === "string"
? value.replace(/[^a-zA-Z0-9 _\-#.]/g, "")
: "";

const SAFE_HEX_COLOR = /^[0-9a-fA-F]{6}$/;
const sanitizeColor = (value: unknown, fallback: string): string => {
const raw = typeof value === "string" ? value : "";
const stripped = raw.replace(/^#/, "");
return SAFE_HEX_COLOR.test(stripped) ? `#${stripped}` : fallback;
};

provider.awareness.setLocalStateField("user", {
name: session?.user?.name || "Anonymous",
color: userColor,
Expand All @@ -350,8 +362,8 @@ const PlaygroundEditor = ({

for (const [clientId, state] of states) {
if (state.user) {
const color = state.user.color || "orange";
const name = state.user.name || "Anonymous";
const color = sanitizeColor(state.user.color, "#30bced");
const name = sanitizeForCss(state.user.name) || "Anonymous";

css += `
.yRemoteSelection-${clientId} {
Expand Down Expand Up @@ -388,7 +400,7 @@ const PlaygroundEditor = ({
`;
}
}
styleEl.innerHTML = css;
styleEl.textContent = css;
};

provider.awareness.on("update", handleAwarenessUpdate);
Expand Down