Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase padding in 404 page #245

Merged

Conversation

Chaitanya-Shahare
Copy link
Contributor

there was no padding for left and right on the custom 404 page, so added some padding for the entire 404 page component

What does this PR do?

  • there was no padding for left and right on the custom 404 page, so added some padding for the entire 404 page component
  • this improves user experience

Fixes #244

Before

Screenshot 2023-10-23 at 12 33 30 PM

After

Screenshot 2023-10-23 at 12 34 00 PM

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How should this be tested?

  1. Go to app.localhost:3000/random
  2. You'll get to a 404 page
  3. Decrease the width of the page in inspect or view it in mobile mode
  4. There must be left and right padding and everything should be clearly visible

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

there was no padding for left and right on the custom 404 page, so added some padding for the entire 404 page component
@github-actions github-actions bot added the bug Something isn't working label Oct 23, 2023
@github-actions
Copy link

github-actions bot commented Oct 23, 2023

Thank you for following the naming conventions! 🙏

Copy link
Collaborator

@hemantwasthere hemantwasthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add px-3 text-center these classes in <div>

@Chaitanya-Shahare
Copy link
Contributor Author

I've added px-3 text-centre to the classes

Copy link
Collaborator

@hemantwasthere hemantwasthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hemantwasthere hemantwasthere merged commit f4b55f2 into piyushgarg-dev:main Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: No padding on custom 404 page
2 participants