feat: add meeting link option #207
Open
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll see if I can manage to pass the data option suggested in #206. |
|
This is actually a lot simpler for now though and is worth considering it's reasonable to think someone would provide meeting link as a baseline for a meeting action |
jonchurch
suggested changes
Nov 22, 2024
There was a problem hiding this comment.
Lets add it as a shorthand as well
https://github.com/pkgjs/meet#shorthand-in-your-custom-meeting-templates
Check the conversions.js file https://github.com/pkgjs/meet/blob/61042a30f295179c24673776877615fa12a6c0bc/lib/conversions.js#L13C1-L25C4
jonchurch
reviewed
Nov 22, 2024
Co-authored-by: Jon Church <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid repeating a template due to a link change, the option to add a link is included, reducing template duplication with a simple link
ref: expressjs/discussions#283