Update README #33
128 new problems found by Qodana for JVM
Qodana for JVM
128 new problems were found
Inspection name | Severity | Problems |
---|---|---|
Unused assignment |
🔶 Warning | 50 |
Statement with empty body |
🔶 Warning | 13 |
Nullability and data flow problems |
🔶 Warning | 12 |
Unnecessary non-capturing group |
🔶 Warning | 10 |
Mismatched query and update of collection |
🔶 Warning | 9 |
Constant values |
🔶 Warning | 4 |
String concatenation as argument to 'StringBuilder.append()' call |
🔶 Warning | 3 |
'Collection.toArray()' call style |
🔶 Warning | 3 |
Malformed format string |
🔶 Warning | 2 |
Overwritten Map, Set, or array element |
🔶 Warning | 2 |
Duplicate branch in alternation |
🔶 Warning | 2 |
Single character alternation |
🔶 Warning | 2 |
Bulk operation can be used instead of iteration |
🔶 Warning | 2 |
Redundant 'Collection.addAll()' call |
🔶 Warning | 1 |
Result of method call ignored |
🔶 Warning | 1 |
Inner class may be 'static' |
🔶 Warning | 1 |
Integer multiplication or shift implicitly cast to 'long' |
🔶 Warning | 1 |
Pointless arithmetic expression |
🔶 Warning | 1 |
Consecutive spaces |
🔶 Warning | 1 |
Sorted collection with non-comparable elements |
🔶 Warning | 1 |
Suspicious 'Collection.toArray()' call |
🔶 Warning | 1 |
Constant values |
◽️ Notice | 6 |
💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report
Detected 119 dependencies
Third-party software list
This page lists the third-party software dependencies used in project
Contact Qodana team
Contact us at [email protected]
- Or via our issue tracker: https://jb.gg/qodana-issue
- Or share your feedback: https://jb.gg/qodana-discussions
Details
This result was published with Qodana GitHub Action
Annotations
Check warning on line 43 in src/main/java/de/gwdg/metadataqa/marc/Utils.java
github-actions / Qodana for JVM
Redundant 'Collection.addAll()' call
'addAll()' call can be replaced with parametrized constructor call
Check notice on line 97 in src/main/java/de/gwdg/metadataqa/marc/utils/alephseq/AlephseqLine.java
github-actions / Qodana for JVM
Constant values
Value `content` is always 'null'
Check notice on line 517 in src/main/java/de/gwdg/metadataqa/marc/utils/marcspec/MARCspecParser.java
github-actions / Qodana for JVM
Constant values
Value `_subfieldMatches` is always 'null'
Check notice on line 80 in src/main/java/de/gwdg/metadataqa/marc/utils/alephseq/MarclineLine.java
github-actions / Qodana for JVM
Constant values
Value `content` is always 'null'
github-actions / Qodana for JVM
Constant values
Value `positionEndObject` is always 'null'
Check notice on line 85 in src/main/java/de/gwdg/metadataqa/marc/utils/alephseq/MarcMakerLine.java
github-actions / Qodana for JVM
Constant values
Value `content` is always 'null'
Check notice on line 332 in src/main/java/de/gwdg/metadataqa/marc/MarcFieldExtractor.java
github-actions / Qodana for JVM
Constant values
Value `value` is always 'null'
Check warning on line 339 in src/main/java/de/gwdg/metadataqa/marc/MarcFactory.java
github-actions / Qodana for JVM
Constant values
Condition `picadf != null` is always `true` when reached
github-actions / Qodana for JVM
Constant values
Condition `this.defaultRecordType == null` is always `false`
Check warning on line 318 in src/main/java/de/gwdg/metadataqa/marc/cli/utils/MappingToJson.java
github-actions / Qodana for JVM
Constant values
Condition `!versionSpecificSubfieldsMap.isEmpty()` is always `true`
Check warning on line 40 in src/main/java/de/gwdg/metadataqa/marc/utils/MarcCacheWrapper.java
github-actions / Qodana for JVM
Constant values
Condition `path != null` is always `true`
github-actions / Qodana for JVM
Nullability and data flow problems
Dereference of `codes` may produce `NullPointerException`
github-actions / Qodana for JVM
Nullability and data flow problems
The call to 'substring' always fails as an argument is out of bounds
Check warning on line 329 in src/main/java/de/gwdg/metadataqa/marc/MarcFieldExtractor.java
github-actions / Qodana for JVM
Nullability and data flow problems
Condition `value instanceof List` is redundant and can be replaced with a null check
github-actions / Qodana for JVM
Nullability and data flow problems
Method invocation `getLabel` may produce `NullPointerException`
github-actions / Qodana for JVM
Nullability and data flow problems
Method invocation `getValue` may produce `NullPointerException`
github-actions / Qodana for JVM
Nullability and data flow problems
Argument `PicaMarcCrosswalkReader.class.getResourceAsStream("/pica/pica-marc.tsv")` might be null
github-actions / Qodana for JVM
Nullability and data flow problems
Method invocation `getFile` may produce `NullPointerException`
Check warning on line 121 in src/main/java/de/gwdg/metadataqa/marc/dao/Control006.java
github-actions / Qodana for JVM
Nullability and data flow problems
Argument `actual` might be null
Check warning on line 50 in src/main/java/de/gwdg/metadataqa/marc/utils/EncodedValueFileReader.java
github-actions / Qodana for JVM
Nullability and data flow problems
Argument `classLoader.getResourceAsStream(fileName)` might be null
github-actions / Qodana for JVM
Nullability and data flow problems
Method invocation `getValue` may produce `NullPointerException`
Check warning on line 14 in src/main/java/de/gwdg/metadataqa/marc/utils/marcspec/Position.java
github-actions / Qodana for JVM
Nullability and data flow problems
Variable is already assigned to this value
Check warning on line 43 in src/main/java/de/gwdg/metadataqa/marc/cli/utils/MarcJsonToSolr.java
github-actions / Qodana for JVM
Nullability and data flow problems
Variable is already assigned to this value
Check warning on line 108 in src/main/java/de/gwdg/metadataqa/marc/analysis/serial/Marc21Serial.java
github-actions / Qodana for JVM
Statement with empty body
`if` statement has empty body
Check warning on line 148 in src/main/java/de/gwdg/metadataqa/marc/dao/record/MarcRecord.java
github-actions / Qodana for JVM
Statement with empty body
`if` statement has empty body