Skip to content

Update README

Update README #33

GitHub Actions / Qodana for JVM completed Jun 4, 2024 in 0s

128 new problems found by Qodana for JVM

Qodana for JVM

128 new problems were found

Inspection name Severity Problems
Unused assignment 🔶 Warning 50
Statement with empty body 🔶 Warning 13
Nullability and data flow problems 🔶 Warning 12
Unnecessary non-capturing group 🔶 Warning 10
Mismatched query and update of collection 🔶 Warning 9
Constant values 🔶 Warning 4
String concatenation as argument to 'StringBuilder.append()' call 🔶 Warning 3
'Collection.toArray()' call style 🔶 Warning 3
Malformed format string 🔶 Warning 2
Overwritten Map, Set, or array element 🔶 Warning 2
Duplicate branch in alternation 🔶 Warning 2
Single character alternation 🔶 Warning 2
Bulk operation can be used instead of iteration 🔶 Warning 2
Redundant 'Collection.addAll()' call 🔶 Warning 1
Result of method call ignored 🔶 Warning 1
Inner class may be 'static' 🔶 Warning 1
Integer multiplication or shift implicitly cast to 'long' 🔶 Warning 1
Pointless arithmetic expression 🔶 Warning 1
Consecutive spaces 🔶 Warning 1
Sorted collection with non-comparable elements 🔶 Warning 1
Suspicious 'Collection.toArray()' call 🔶 Warning 1
Constant values ◽️ Notice 6

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Detected 119 dependencies

Third-party software list

This page lists the third-party software dependencies used in project

Dependency Version Licenses
accessors-smart 2.5.0 Apache-2.0
activation 1.1.1 CDDL-1.0
GPL-2.0-only
ORACLE-OPENJDK-EXCEPTION-2.0
aircompressor 0.25 Apache-2.0
arrow-format 12.0.1 Apache-2.0
arrow-memory-core 12.0.1 Apache-2.0
arrow-memory-netty 12.0.1 Apache-2.0
arrow-vector 12.0.1 Apache-2.0
audience-annotations 0.13.0 Apache-2.0
avro-ipc 1.11.2 Apache-2.0
avro-mapred 1.11.2 Apache-2.0
avro 1.11.2 Apache-2.0
byte-buddy 1.14.9 Apache-2.0
commons-beanutils 1.9.4 Apache-2.0
commons-cli 1.7.0 Apache-2.0
commons-codec 1.16.0 Apache-2.0
commons-collections 3.2.2 Apache-2.0
commons-collections4 4.4 Apache-2.0
commons-compress 1.23.0 Apache-2.0
commons-crypto 1.1.0 Apache-2.0
commons-httpclient 3.1 Apache-2.0
commons-io 2.16.1 Apache-2.0
commons-lang3 3.14.0 Apache-2.0
commons-logging 1.0.4 Apache-2.0
commons-math3 3.6.1 Apache-2.0
commons-text 1.11.0 Apache-2.0
compress-lzf 1.1.2 Apache-2.0
curator-client 2.13.0 Apache-2.0
curator-framework 2.13.0 Apache-2.0
curator-recipes 2.13.0 Apache-2.0
datasketches-java 3.3.0 Apache-2.0
datasketches-memory 2.1.0 Apache-2.0
PROTOBUF
flatbuffers-java 1.12.0 Apache-2.0
gson 2.10.1 Apache-2.0
hadoop-client-api 3.3.4 Apache-2.0
hadoop-client-runtime 3.3.4 BSD-3-Clause
hive-storage-api 2.8.1 Apache-2.0
http2-client 10.0.19 Apache-2.0
EPL-2.0
http2-common 10.0.19 Apache-2.0
EPL-2.0
http2-hpack 10.0.19 Apache-2.0
EPL-2.0
http2-http-client-transport 10.0.19 Apache-2.0
EPL-2.0
httpclient 4.5.14 Apache-2.0
httpcore 4.4.16 Apache-2.0
httpmime 4.5.14 Apache-2.0
ivy 2.5.1 Apache-2.0
COMPONENTACE-JCRAFT
MIT
jackson-annotations 2.17.0 Apache-2.0
jackson-core 2.17.0 Apache-2.0
jackson-databind 2.17.0 Apache-2.0
jackson-datatype-jsr310 2.15.1 Apache-2.0
jackson-module-scala_2.13 2.15.2 Apache-2.0
jakarta.inject 2.6.1 Classpath-exception-2.0
EPL-2.0
GPL-2.0-only
jakarta.servlet-api 4.0.3 EPL-2.0
GPL-1.0-or-later
jakarta.ws.rs-api 2.1.6 Classpath-exception-2.0
EPL-2.0
GPL-2.0-only
javassist 3.28.0-ga Apache-2.0
LGPL-2.0-or-later
MPL-1.1
jcl-over-slf4j 2.0.10 MIT
jersey-client 2.40 Classpath-exception-2.0
EPL-2.0
GPL-2.0-only
jersey-container-servlet-core 2.40 Classpath-exception-2.0
EPL-2.0
GPL-2.0-only
jersey-container-servlet 2.40 Classpath-exception-2.0
EPL-2.0
GPL-2.0-only
jetty-alpn-client 10.0.19 Apache-2.0
EPL-2.0
jetty-alpn-java-client 10.0.19 Apache-2.0
EPL-2.0
jetty-client 10.0.19 Apache-2.0
EPL-2.0
jetty-http 10.0.19 Apache-2.0
EPL-2.0
jetty-io 10.0.19 Apache-2.0
EPL-2.0
jetty-util 10.0.19 Apache-2.0
EPL-2.0
joda-time 2.12.5 Apache-2.0
json-smart 2.5.0 Apache-2.0
jsr305 3.0.2 Apache-2.0
jul-to-slf4j 2.0.7 MIT
kryo-shaded 4.0.2 BSD-3-Clause
leveldbjni-all 1.8 BSD-3-Clause
log4j-1.2-api 2.20.0 Apache-2.0
log4j-api 2.23.1 Apache-2.0
log4j-core 2.23.1 Apache-2.0
metadata-qa-api 0.9.4 GPL-3.0-only
minlog 1.3.0 BSD-3-Clause
netty-all 4.1.96.final Apache-2.0
netty-common 4.1.96.final Apache-2.0
netty-tcnative-boringssl-static 2.0.61.final Apache-2.0
objenesis 2.5.1 Apache-2.0
opencsv 5.9 Apache-2.0
orc-shims 1.9.2 Apache-2.0
oro 2.0.8 Apache-1.1
parquet-column 1.13.1 Apache-2.0
parquet-common 1.13.1 Apache-2.0
parquet-encoding 1.13.1 Apache-2.0
parquet-hadoop 1.13.1 Apache-2.0
parquet-jackson 1.13.1 Apache-2.0
pickle 1.3 MIT
py4j 0.10.9.7 BSD-3-Clause
reflections 0.10.2 Apache-2.0
WTFPL
scala-library 2.13.8 Apache-2.0
scala-reflect 2.13.8 Apache-2.0
semver4j 5.2.2 MIT
slf4j-api 2.0.12 MIT
slf4j-simple 2.0.12 MIT
snakeyaml 2.2 Apache-2.0
solr-api 9.4.1 Apache-2.0
MIT
solr-solrj-streaming 9.4.1 Apache-2.0
MIT
solr-solrj-zookeeper 9.4.1 Apache-2.0
MIT
solr-solrj 9.4.1 Apache-2.0
MIT
spark-catalyst_2.13 3.5.1 Apache-2.0
spark-common-utils_2.13 3.5.1 Apache-2.0
spark-core_2.13 3.5.1 Apache-2.0
spark-kvstore_2.13 3.5.1 Apache-2.0
spark-launcher_2.13 3.5.1 Apache-2.0
spark-network-common_2.13 3.5.1 Apache-2.0
spark-network-shuffle_2.13 3.5.1 Apache-2.0
spark-sketch_2.13 3.5.1 Apache-2.0
spark-sql-api_2.13 3.5.1 Apache-2.0
spark-sql_2.13 3.5.1 Apache-2.0
spark-tags_2.13 3.5.1 Apache-2.0
spark-unsafe_2.13 3.5.1 Apache-2.0
sqlite-jdbc 3.45.2.0 Apache-2.0
stream 2.9.6 Apache-2.0
swagger-annotations 2.2.17 Apache-2.0
threeten-extra 1.7.1 BSD-3-Clause
univocity-parsers 2.9.1 Apache-2.0
ws-commons-util 1.0.1 Apache-2.0
xbean-asm9-shaded 4.23 Apache-2.0
xml-apis 1.0.b2 Apache-1.1
Contact Qodana team

Contact us at [email protected]

Details

This result was published with Qodana GitHub Action

Annotations

Check warning on line 43 in src/main/java/de/gwdg/metadataqa/marc/Utils.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Redundant 'Collection.addAll()' call

'addAll()' call can be replaced with parametrized constructor call

Check notice on line 97 in src/main/java/de/gwdg/metadataqa/marc/utils/alephseq/AlephseqLine.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Constant values

Value `content` is always 'null'

Check notice on line 517 in src/main/java/de/gwdg/metadataqa/marc/utils/marcspec/MARCspecParser.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Constant values

Value `_subfieldMatches` is always 'null'

Check notice on line 80 in src/main/java/de/gwdg/metadataqa/marc/utils/alephseq/MarclineLine.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Constant values

Value `content` is always 'null'

Check notice on line 375 in src/main/java/de/gwdg/metadataqa/marc/utils/unimarc/UnimarcSchemaReader.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Constant values

Value `positionEndObject` is always 'null'

Check notice on line 85 in src/main/java/de/gwdg/metadataqa/marc/utils/alephseq/MarcMakerLine.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Constant values

Value `content` is always 'null'

Check notice on line 332 in src/main/java/de/gwdg/metadataqa/marc/MarcFieldExtractor.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Constant values

Value `value` is always 'null'

Check warning on line 339 in src/main/java/de/gwdg/metadataqa/marc/MarcFactory.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Constant values

Condition `picadf != null` is always `true` when reached

Check warning on line 386 in src/main/java/de/gwdg/metadataqa/marc/cli/parameters/CommonParameters.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Constant values

Condition `this.defaultRecordType == null` is always `false`

Check warning on line 318 in src/main/java/de/gwdg/metadataqa/marc/cli/utils/MappingToJson.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Constant values

Condition `!versionSpecificSubfieldsMap.isEmpty()` is always `true`

Check warning on line 40 in src/main/java/de/gwdg/metadataqa/marc/utils/MarcCacheWrapper.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Constant values

Condition `path != null` is always `true`

Check warning on line 63 in src/main/java/de/gwdg/metadataqa/marc/cli/utils/ignorablerecords/CriteriumPica.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Nullability and data flow problems

Dereference of `codes` may produce `NullPointerException`

Check warning on line 83 in src/main/java/de/gwdg/metadataqa/marc/utils/pica/path/PicaPathParser.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Nullability and data flow problems

The call to 'substring' always fails as an argument is out of bounds

Check warning on line 329 in src/main/java/de/gwdg/metadataqa/marc/MarcFieldExtractor.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Nullability and data flow problems

Condition `value instanceof List` is redundant and can be replaced with a null check

Check warning on line 49 in src/main/java/de/gwdg/metadataqa/marc/utils/ControlFieldStructureVisualization.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Nullability and data flow problems

Method invocation `getLabel` may produce `NullPointerException`

Check warning on line 21 in src/main/java/de/gwdg/metadataqa/marc/utils/ControlFieldStructureVisualization.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Nullability and data flow problems

Method invocation `getValue` may produce `NullPointerException`

Check warning on line 46 in src/main/java/de/gwdg/metadataqa/marc/utils/pica/crosswalk/PicaMarcCrosswalkReader.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Nullability and data flow problems

Argument `PicaMarcCrosswalkReader.class.getResourceAsStream("/pica/pica-marc.tsv")` might be null

Check warning on line 47 in src/main/java/de/gwdg/metadataqa/marc/analysis/functional/UnimarcFrbrFunctionLister.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Nullability and data flow problems

Method invocation `getFile` may produce `NullPointerException`

Check warning on line 121 in src/main/java/de/gwdg/metadataqa/marc/dao/Control006.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Nullability and data flow problems

Argument `actual` might be null

Check warning on line 50 in src/main/java/de/gwdg/metadataqa/marc/utils/EncodedValueFileReader.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Nullability and data flow problems

Argument `classLoader.getResourceAsStream(fileName)` might be null

Check warning on line 77 in src/main/java/de/gwdg/metadataqa/marc/utils/ControlFieldStructureVisualization.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Nullability and data flow problems

Method invocation `getValue` may produce `NullPointerException`

Check warning on line 14 in src/main/java/de/gwdg/metadataqa/marc/utils/marcspec/Position.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Nullability and data flow problems

Variable is already assigned to this value

Check warning on line 43 in src/main/java/de/gwdg/metadataqa/marc/cli/utils/MarcJsonToSolr.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Nullability and data flow problems

Variable is already assigned to this value

Check warning on line 108 in src/main/java/de/gwdg/metadataqa/marc/analysis/serial/Marc21Serial.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Statement with empty body

`if` statement has empty body

Check warning on line 148 in src/main/java/de/gwdg/metadataqa/marc/dao/record/MarcRecord.java

See this annotation in the file changed.

@github-actions github-actions / Qodana for JVM

Statement with empty body

`if` statement has empty body