Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub actions revised #1

Merged
merged 11 commits into from
Dec 12, 2019
Merged

Conversation

ashryanbeats
Copy link

Description

  • [action] Now running jobs on Mac and Win
  • [action] Ensuring xdpm install action doesn't fail due to non-existent target dirs by using mkdir/md
  • [lib/validate.js] Ensuring xdpm validate action doesn't fail by checking if .icons property existing before invoking .forEach

Related Issue

AdobeXD#35

Motivation and Context

Trying to ensure we don't end up with pesky failure annotations in our actions results when we actually intend for the action to fail.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pklaschka
Copy link
Owner

This is great 👍

@pklaschka pklaschka merged commit 3ba5d9c into pklaschka:master Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants