Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub actions #3

Merged
merged 6 commits into from
Jan 3, 2020
Merged

Conversation

ashryanbeats
Copy link

Description

I did a little hacking on the actions you set up:
https://github.com/ashryanbeats/xdpm/blob/github-actions/.github/workflows/cli-test.yml

Here's the result:
https://github.com/ashryanbeats/xdpm/runs/346161827

You'll note that there are no more failure annotations. This may not be the final result we're looking for, but I'm hoping this is helpful.

Related Issue

AdobeXD#35

Motivation and Context

In this fork, the changes worth noting:

  • [action] Now running jobs on Mac and Win
  • [action] Ensuring xdpm install action doesn't fail due to non-existent target dirs by using mkdir/md
  • [lib/validate.js] Ensuring xdpm validate action doesn't fail by checking if .icons property exists before invoking .forEach

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@pklaschka pklaschka merged commit ae4c00c into pklaschka:github-actions Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants