Feature/Anomaly: 귀신 손 이상현상 및 불태우기 나이아가라 #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
수정 필요
귀신 손 + 달리기X
내가 불태워짐
나도 몰라유~~
kwkim526
reviewed
Jan 8, 2026
KaneBigNose
reviewed
Jan 8, 2026
Collaborator
KaneBigNose
left a comment
KaneBigNose
left a comment
There was a problem hiding this comment.
확인했습니다.
전반적으로 불필요한 안전 검사가 많아 코드가 길어지고 가독성이 떨어집니다.
| Move->MaxWalkSpeed = LockedWalkSpeed; | ||
|
|
||
| GetWorld()->GetTimerManager().ClearTimer(ReapplySpeedHandle); | ||
| GetWorld()->GetTimerManager().SetTimer(ReapplySpeedHandle, FTimerDelegate::CreateLambda([this]() |
Collaborator
There was a problem hiding this comment.
CreateWeakLamda로 변경 바랍니다
| GetWorld()->GetTimerManager().ClearTimer(ReapplySpeedHandle); | ||
| GetWorld()->GetTimerManager().SetTimer(ReapplySpeedHandle, FTimerDelegate::CreateLambda([this]() | ||
| { | ||
| ACharacter* P = UGameplayStatics::GetPlayerCharacter(GetWorld(), 0); |
Collaborator
There was a problem hiding this comment.
지역변수라도 변수명이 너무 짧으면 의미 전달도 힘들고 충돌 가능성도 높아집니다
Collaborator
There was a problem hiding this comment.
전반적으로 플레이어 캐릭터나 플레이어 컨트롤러를 들고와서 많이 쓰는데 멤버 변수로 캐싱하여 사용하는 것이 더 효율적으로 보입니다
Collaborator
|
현재 충돌이 발생하였습니다. 확인 바랍니다. |
bumyee11
reviewed
Jan 10, 2026
Collaborator
bumyee11
left a comment
bumyee11
left a comment
There was a problem hiding this comment.
확인했습니다.
에셋을 임포트하면서 발생하는 가비지 파일들은 정리 부탁드립니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
정기회의 13차-1차 PR (심서은, Anomaly)
🎮 개발한 핵심 기능
🐛 고친 버그 & 코드 목록
📷 참고 자료
GhostHand.mp4
Fire.mp4
🔍 리뷰가 필요한 부분