Use regexp2cg for optimized code generation of regex patterns
#54
+1,573
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odannyc
commented
Oct 15, 2024
| return nil, fmt.Errorf("error compiling regex: %s", err) | ||
| } | ||
|
|
||
| func NewCoreBPE(encoder map[string]int, specialTokensEncoder map[string]int, regex *regexp2.Regexp) (*CoreBPE, error) { |
There was a problem hiding this comment.
The regex compilation needs to be known at compile time, which means that we need to compile the regex higher up the stack, hence the reason why we pass regexp2.Regexp here instead of a string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses the new regexp2cg that is recommended for the extra performance boost as outlined here: https://github.com/dlclark/regexp2?tab=readme-ov-file#new-code-generation
If new regex patterns are added or updated this command needs to be ran: