pkp/pkp-lib#9799 Record review assignment view action #10233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vitaliy-1
force-pushed
the
i9799_review_viewed
branch
from
3c6ac0e to
df8f65d
Compare
This was referenced Jul 22, 2024
| @@ -41,6 +41,7 @@ class ReviewAssignment extends \PKP\core\DataObject | |||
| public const REVIEW_ASSIGNMENT_CONSIDERED = 3; // Has been marked considered by an editor | |||
| public const REVIEW_ASSIGNMENT_UNCONSIDERED = 1; // Considered status has been revoked by an editor and is awaiting re-confirmation by an editor | |||
| public const REVIEW_ASSIGNMENT_RECONSIDERED = 2; // Considered status has been granted again by an editor | |||
| public const REVIEW_ASSIGNMENT_VIEWED = 4; // Editor opened a review assignment but hasn't marked it as considered yet | |||
|
|
|||
There was a problem hiding this comment.
Could we also add REVIEW_ASSIGNMENT_STATUS_VIEWED?
Vitaliy-1
force-pushed
the
i9799_review_viewed
branch
from
df8f65d to
f83754d
Compare
| // If it was viewed by the editor but not confirmed | ||
| } else { | ||
| return self::REVIEW_ASSIGNMENT_STATUS_VIEWED; | ||
| } |
There was a problem hiding this comment.
I would expect to return REVIEW_ASSIGNMENT_STATUS_VIEWED, when $this->getConsidered() === REVIEW_ASSIGNMENT_VIEWED.
But it has been long day...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.