pkp/pkp-lib#11557 Use single format for keywords in publication object #11764
+57
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
touhidurabir
reviewed
Sep 9, 2025
There was a problem hiding this comment.
Hi @ajnyga , added some initial comments, nothing critical . But I am unable to test the PR locally as it seems bit behind the current state , Need a rebase with latest version . I will do more detail review once it's rebased and tests are passing(as failing in unit test) .
BTW on thing we need some decide on retrieving the specific key like name again from DB or directly from the publication object to reduce DB calls .
|
I think the failing unit tests have something todo with using the publication object to fetch the keywords and subjects in dc11? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.