pkp/pkp-lib#3304 Replace homebrew caching with Stash #5743
Conversation
asmecher
force-pushed
the
i3304-fix
branch
4 times, most recently
from
c0516c2 to
bc2555d
Compare
| $result->Close(); | ||
| $pool->save($item->set($returner)); |
There was a problem hiding this comment.
@asmecher I'm wondering if this will cause a problem in cases where _fromRow() fetches dependent entities. So let's say I've got a Submission and it's in cache. Then I edit one of it's Publication objects. I've cleared the cache on the Publication object but not the Submission. When I go to get the Submission again it's going to return an object with nested Publications, one of which will be out of date.
There was a problem hiding this comment.
Yes, I'm still working out details here... Off the top of my head, I'd like to exclude dependent entities from the serialized object and have them fetched separately (from the cache if possible) if we're going to use "deep caching" throughout the system. Another option (which is what we used to do) is to enable persistent caching only for high-volume scenarios like the reader front-end where mid-request updates don't happen.
asmecher
force-pushed
the
i3304-fix
branch
2 times, most recently
from
7fa2289 to
583dec4
Compare
No description provided.