pkp/pkp-lib#9295 composbale for issue assignment and added namespace(submission and publication) for status const

Author: touhidurabir

public/globals.js

@@ -96,14 +96,18 @@ window.pkp = {
 		ROLE_ID_SUB_EDITOR: 17,
 		ROLE_ID_SUBSCRIPTION_MANAGER: 2097152,
 		STAGE_STATUS_SUBMISSION_UNASSIGNED: 1,
-		STATUS_QUEUED: 1,
-		STATUS_PUBLISHED: 3,
-		STATUS_DECLINED: 4,
-		STATUS_SCHEDULED: 5,
-		PUBLICATION_STATUS_QUEUED: 1,
-		PUBLICATION_STATUS_PUBLISHED: 3,
-		PUBLICATION_STATUS_DECLINED: 4,
-		PUBLICATION_STATUS_SCHEDULED: 5,
+		submission: {
+			STATUS_QUEUED: 1,
+			STATUS_PUBLISHED: 3,
+			STATUS_DECLINED: 4,
+			STATUS_SCHEDULED: 5,
+		},
+		publication: {
+			STATUS_QUEUED: 1,
+			STATUS_PUBLISHED: 3,
+			STATUS_DECLINED: 4,
+			STATUS_SCHEDULED: 5,
+		},
 		WORKFLOW_STAGE_ID_SUBMISSION: 1,
 		WORKFLOW_STAGE_ID_INTERNAL_REVIEW: 2,
 		WORKFLOW_STAGE_ID_EXTERNAL_REVIEW: 3,

src/components/Form/Form.vue

@@ -71,7 +71,6 @@
 				@show-locale="showLocale"
 				@cancel="cancel"
 				@set-errors="setErrors"
-				@set-field-required="setFieldRequired"
 			/>
 		</div>
 	</form>
@@ -162,7 +161,6 @@ export default {
 			currentPage: '',
 			isSaving: false,
 			lastSaveTimestamp: -1,
-			fieldRequiredStates: {}, // track field required states for dynamic fields
 		};
 	},
 	computed: {
@@ -388,16 +386,6 @@ export default {
 					return;
 				}
 
-				// Check if field has custom required state
-				if (field.name in this.fieldRequiredStates) {
-					const isFieldRequired = this.fieldRequiredStates[field.name];
-					// check if Field is required by dynamic update and return if not
-					// otherwise continue with default checks
-					if (!isFieldRequired) {
-						return;
-					}
-				}
-
 				let missingValue = false;
 
 				// Only require the primary locale by default for multilingual fields

src/components/Form/FormGroup.vue

@@ -91,7 +91,6 @@ import FieldRichTextarea from './fields/FieldRichTextarea.vue';
 import FieldRichText from './fields/FieldRichText.vue';
 import FieldSelect from './fields/FieldSelect.vue';
 import FieldSelectIssues from './fields/FieldSelectIssues.vue';
-import FieldIssueSelection from './fields/FieldIssueSelection.vue';
 import FieldSelectSubmissions from './fields/FieldSelectSubmissions.vue';
 import FieldSelectUsers from './fields/FieldSelectUsers.vue';
 import FieldShowEnsuringLink from './fields/FieldShowEnsuringLink.vue';
@@ -128,7 +127,6 @@ export default {
 		FieldRichText,
 		FieldSelect,
 		FieldSelectIssues,
-		FieldIssueSelection,
 		FieldSelectSubmissions,
 		FieldSelectUsers,
 		FieldShowEnsuringLink,
@@ -242,13 +240,6 @@ export default {
 			}
 			this.$emit('set-errors', {...newErrors});
 		},
-
-		/**
-		 * Forward field required events to the form page
-		 */
-		setFieldRequired: function (fieldName, isRequired) {
-			this.$emit('set-field-required', fieldName, isRequired);
-		},
 	},
 };
 </script>

src/components/Form/FormPage.vue

@@ -235,13 +235,6 @@ export default {
 		setErrors: function (errors) {
 			this.$emit('set-errors', errors);
 		},
-
-		/**
-		 * Forward field required events to the form
-		 */
-		setFieldRequired: function (fieldName, isRequired) {
-			this.$emit('set-field-required', fieldName, isRequired);
-		},
 	},
 };
 </script>