Maintenance updates #358
Merged
Maintenance updates #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
eatyourgreens
commented
Mar 6, 2024
eatyourgreens
commented
- update outdated dependencies.
- refactors to fix build warnings.
Patch and minor version updates for frontend dependencies.
Clean up unused variables and React globals.
* refactor: Clean up useEffect build warnings Fix build warnings in the frontend. Either remove effect hooks, where they can be replaced, or add the missing dependencies to the effect hook. See https://react.dev/learn/you-might-not-need-an-effect * Wrap VariableRow callbacks in useCallback * refactor slider onChange with useCallback
Replace `useEffect` hooks for form submission with a `useInterval` hook that sets a timeout and runs a callback if a form has unsaved changes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #358 +/- ##
=======================================
Coverage 76.35% 76.35%
=======================================
Files 95 95
Lines 5379 5379
=======================================
Hits 4107 4107
Misses 1272 1272 ☔ View full report in Codecov by Sentry. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.