fix: infinite re-renders for projects without datasets #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that `useDataset` returns the same empty array for groups and biomarkers, in the case where a project has no datasets. Otherwise, hooks that depend on dataset groups or biomarkers will be triggered to run on every render.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #404 +/- ##
===============================================
+ Coverage 76.35% 76.71% +0.36%
===============================================
Files 95 107 +12
Lines 5379 5557 +178
===============================================
+ Hits 4107 4263 +156
- Misses 1272 1294 +22 ☔ View full report in Codecov by Sentry. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that
useDatasetreturns the same empty array for groups and biomarkers, inthe case where a project has no datasets. Otherwise, hooks that depend on dataset groups
or biomarkers will be triggered to run on every render.
simulateend-point calls if the first simulate fails #401.