Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend): remove dummy time intervals and thresholds #576

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

eatyourgreens
Copy link
Collaborator

  • Remove dummy data for secondary parameters.
  • Update useParameters for the case where we haven't defined any intervals yet.

- Remove dummy data for secondary parameters.
- Update `useParameters` for the case where we haven't defined any intervals yet.
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.17%. Comparing base (c227f57) to head (a41b82d).
Report is 14 commits behind head on ui-enhancements.

Additional details and impacted files
@@               Coverage Diff                @@
##           ui-enhancements     #576   +/-   ##
================================================
  Coverage            76.17%   76.17%           
================================================
  Files                  108      108           
  Lines                 5600     5600           
================================================
  Hits                  4266     4266           
  Misses                1334     1334           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

Copy link

Quality Gate Failed Quality Gate failed for 'pkpdapp-team_pkpdapp_frontend'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@eatyourgreens eatyourgreens merged commit 5ec4dd8 into ui-enhancements Nov 21, 2024
8 of 9 checks passed
@eatyourgreens eatyourgreens deleted the remove-dummy-data branch November 21, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant