Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add thresholds to variable model #584

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

eatyourgreens
Copy link
Collaborator

@eatyourgreens eatyourgreens commented Nov 25, 2024

Add variable.lower_threshold and variable.upper_threshold to the variable model, so that thresholds are saved in the app database.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.52%. Comparing base (c227f57) to head (872ea54).
Report is 24 commits behind head on ui-enhancements.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           ui-enhancements     #584      +/-   ##
===================================================
+ Coverage            76.17%   76.52%   +0.34%     
===================================================
  Files                  108      110       +2     
  Lines                 5600     5645      +45     
===================================================
+ Hits                  4266     4320      +54     
+ Misses                1334     1325       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Add `variable.lower_threshold` and `variable.upper_threshold` to the variable model, so that thresholds are saved in the app database.
Copy link

Copy link

Quality Gate Failed Quality Gate failed for 'pkpdapp-team_pkpdapp_frontend'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@eatyourgreens eatyourgreens merged commit 40f0354 into ui-enhancements Nov 25, 2024
7 of 8 checks passed
@eatyourgreens eatyourgreens deleted the variable-thresholds branch November 25, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant