Conversation
Collaborator
wniestroj
commented
Nov 26, 2024
wniestroj
commented
…m LoadData.tsx, Added handle for onCancel on dataset edition
PKPDX-11 PKPDX-13
PKPDX-12 Add 'Previous' and 'Cancel' buttons
`setPrimaryCohort` has been replaced by `setGroupColumn`.
PKPDX-15 PKPDX-25
Co-authored-by: Jim O'Donnell <james.odonnell@dtc.ox.ac.uk>
PKPDX-16; PKPDX-17; PKPDX-18
…t on Upload Data step
perf: only simulate when on simulation page
update aria-label to more specific label Co-authored-by: Jim O'Donnell <james.odonnell@dtc.ox.ac.uk>
# Conflicts: # frontend-v2/src/features/main/Sidebar.tsx
…to PKPDX-29 # Conflicts: # frontend-v2/src/features/main/Sidebar.tsx
…ndow.resize event; added additional plot widths
- Remove dummy data for secondary parameters. - Update `useParameters` for the case where we haven't defined any intervals yet.
Store time interval units as objects with conversion factors, symbols, and unit IDs.
…on sidebar collapsible sections to be collapsed by default; Dislpay Parameter input below the slider
* PKPDX-29 Add headers to results tables * Remove unnecessary quotation mark * Fix plots being constantly resized when changing layout * Fix plots being constantly resized when changing layout * Added controlling of plots width in dependence to resolution/scale * PKPDX-30 Added collapsible sidebar, added animations for main content and simulations sidebar * Refactor of collapsible sidebar, added context controlling the classes and expansion of sidebar * Revert div to box * fix: merge conflict * Update frontend-v2/src/features/main/Sidebar.tsx update aria-label to more specific label Co-authored-by: Jim O'Donnell <james.odonnell@dtc.ox.ac.uk> * Changed aria-label for main navigation; added resizing of plots on window.resize event; added additional plot widths * Refactored plot widths to be calucalated on container width; Simulation sidebar collapsible sections to be collapsed by default; Dislpay Parameter input below the slider --------- Co-authored-by: Jim O'Donnell <james.odonnell@dtc.ox.ac.uk>
Fix a couple of small TS errors in the `Simulations` component.
Run a type check, install, and build for the frontend in the CI pipeline.
Bump outdated packages with `yarn upgrade-interactive`.
- New Django model, `TimeInterval`, representing time intervals for secondary parameters. - Update the combined model serialiser so that it can save `model.time_intervals`. - Update the OpenAPI schema in the backend and frontend. - Update the React app to use the new OpenAPI models.
Normalise all Results times to hours, for the time being.
Add `variable.lower_threshold` and `variable.upper_threshold` to the variable model, so that thresholds are saved in the app database.
Pull data-fetching logic out of the `ThresholdsTable` component and into custom hooks.
- Store display units for variable thresholds separately from variable units. - Normalise threshold units to `pmol/L` in the Results tables.
Return empty arrays by default from `useUnits` and `useVariables`.
# Conflicts: # frontend-v2/src/App.tsx # frontend-v2/src/features/simulation/Simulations.tsx
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #592 +/- ##
==========================================
+ Coverage 76.26% 76.55% +0.28%
==========================================
Files 108 111 +3
Lines 5591 5651 +60
==========================================
+ Hits 4264 4326 +62
+ Misses 1327 1325 -2 ☔ View full report in Codecov by Sentry. |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.