PKPDX 34

[wniestroj]

No description provided.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.70%. Comparing base (efb0614) to head (18209ee).
Report is 5 commits behind head on ui-enhancements.

Additional details and impacted files

@@               Coverage Diff                @@
##           ui-enhancements     #613   +/-   ##
================================================
  Coverage            76.70%   76.70%           
================================================
  Files                  117      117           
  Lines                 5705     5705           
================================================
  Hits                  4376     4376           
  Misses                1329     1329           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarqubecloud]

Quality Gate passed for 'pkpdapp'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sonarqubecloud]

Quality Gate failed for 'pkpdapp-team_pkpdapp_frontend'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

[eatyourgreens]

Looks good.

One small problem: The form validation error messages are cut off by the container box height now.

[wniestroj]

@eatyourgreens Is the scroll not popping up? I'm struggling to recreate such case - for me either the container height increases, making space to display the error message, or if after adding the error message the max height is exceeded, the scroll shows up. Could you provide me with your resolution and scales?
error.webm

[eatyourgreens]

You can scroll the container down, but you probably shouldn't have to scroll down to see the error essage. A little more vertical padding at the bottom might be useful.

This isn't a blocking comment, though. Just a small annoyance in the UX of the form.

[wniestroj]

@eatyourgreens I assumed that as the input has the border changed to red indicating an error, that shouldn't be a problem, however I see your point. Let's merge this one, so that the Model page can be tested and I will fix that issue with other fixes