Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI enhancements fixes #614

Merged
merged 5 commits into from
Nov 29, 2024
Merged

UI enhancements fixes #614

merged 5 commits into from
Nov 29, 2024

Conversation

wniestroj
Copy link
Collaborator

Fix project description not working; Fix doses input getting narrow; Fix unit id being displayed instead of symbol

@codecov Codecov
Copy link

codecov bot commented Nov 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.70%. Comparing base (003f67b) to head (efb0614).
Report is 17 commits behind head on ui-enhancements.

Additional details and impacted files 
@@               Coverage Diff                @@
##           ui-enhancements     #614   +/-   ##
================================================
  Coverage            76.70%   76.70%           
================================================
  Files                  117      117           
  Lines                 5705     5705           
================================================
  Hits                  4376     4376           
  Misses                1329     1329

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

martinjrobins
martinjrobins approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@martinjrobins martinjrobins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a debug log to get rid of

frontend-v2/src/features/drug/Drug.tsx Outdated
@@ -224,7 +224,7 @@ const Drug: FC = () => {
setIsEditIndex(isEdit ? index : null);
};

console.log("efficacy_experiments", efficacy_experiments);
console.log("units", units);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was left in my mistake

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, already removed

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'pkpdapp'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed for 'pkpdapp-team_pkpdapp_frontend'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@wniestroj wniestroj merged commit 647a1d5 into ui-enhancements Nov 29, 2024
9 of 10 checks passed
@wniestroj wniestroj deleted the ui-enhancements-fixes branch November 29, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinjrobins martinjrobins martinjrobins approved these changes

@eatyourgreens eatyourgreens Awaiting requested review from eatyourgreens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wniestroj @martinjrobins