Feedback changes and fixes #615
Conversation
…lapse; Fix height of plots on ultra wide resolutions; Fix Simulation Sidebar view for high scales
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## ui-enhancements #615 +/- ##
================================================
Coverage 76.70% 76.70%
================================================
Files 117 117
Lines 5705 5705
================================================
Hits 4376 4376
Misses 1329 1329 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
I can see the toolbar for simulation plots now, but it's missing the option to edit the plot axes.
Here's production (on the main branch.) The toolbar should have options to reset the axes, edit the axes, and remove the plot. It might also be worth checking the new design with plots that have y-axes defined for both the left and righthand sides of the plot. I think the new container might cut off the righthand y-axis.
|
@eatyourgreens I struggled to find this case, however, I believe I have. What I found is that for wide viewports (over 2500 width), when there are supposed to be three columns, but only two plots are displayed, the widths or the positioning of plots was off making the plots overlap. I have refactored it so that there cannot be more columns then plots - so if only one plot is displayed, there will be only one column, two columns for two plots |
|
@wniestroj I can still see the bug on a screen with four plots. Zooming out, then back in again, fixes it. Screen.Recording.2024-12-03.at.11.43.44.mov |
|
Happy for this to be merged, though, if you want to look at the plot width separately. |
|
@eatyourgreens Could you provide me with a path to recreate a view with horizontal scroll visible for the four plots? In this merge request I have added a useEffect that is triggered whenever the number of the plots changes, firing up the resize event. This should resize the plots whenever a plot is added/removed, but for me it always sets the correct width whenever the plots are rendered for the first time as well and I wasn't able to recreate this issue. I have added additional dependencies to that useEffect for data length and model, hopefully it should fix this issue. Would you be able to retest it, as I cannot recreate this issue? If that will not fix the issue, I will revert those changes and merge this request, so that other fixes can be tested and I'll get back to that one with another merge request |
|
@wniestroj I'm not seeing that bug now.All I've been doing is loading the app, selecting a project, then opening the Simulations tab. Screen.Recording.2024-12-03.at.13.02.17.mov |
|
@eatyourgreens Awesome, glad to hear that. On another note - on the last video it seems like the scroll from the project's page is overflowing the viewport creating a scroll on the whole page - is that correct, or is this just an issue when recording a screen (I have similar issue whenever I'm recording the screen using Nimbus addon to chrome). If the scroll if overflowing - could you provide me with your resolution and the scale of your browser, so that I could reproduce this issue? |
|
That scroll is always there, even if I'm not recording the screen. I'm on a fairly wide display: 1920 by 1080. |
|
|
Simulations sidebar - no layout options selected by default
Simulations sidebar - selecting both layouts deselects both options
Navigation - Fix pkpd version overlap navigation buttons on high scales
Simulation page - fix plots get smaller after each resize/sidebar collapse; Fix height of plots on ultra wide resolutions; Fix simulation Sidebar view for high scales
Simulation page - fix plots box having wrong dimensions on first plot render
Global - Input width and table height adjustments for scales up to 200%
Project page - Disable edit button on shared projects
Simulation page - Add confirmation box to removing plot