Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vertical scroll on horizontal layout #616

Merged
merged 15 commits into from
Dec 5, 2024
Merged

Fix vertical scroll on horizontal layout #616

merged 15 commits into from
Dec 5, 2024

Conversation

wniestroj
Copy link
Collaborator

image

@wniestroj
Simulations sidebar - no layout options selected by default
9bd0094
@wniestroj
Simulations sidebar - selecting both layouts deselects both options
0bf8e7b
@wniestroj
Fix pkpd version overlap navigation buttons on high scales
ac6007c
@wniestroj
Simulation page - fix plots get smaller after each resize/sidebar col…
c79c6e0 
…lapse; Fix height of plots on ultra wide resolutions; Fix Simulation Sidebar view for high scales
@wniestroj
Simulation page - fix plots box having wrong dimensions on first plot…
bae390c 
… render
@wniestroj
Input width and table height adjustments for scales up to 200%
4d8a327
@wniestroj
Disable edit button on shared projects
b415afa
@wniestroj
Simulation page - Add confirmation box to removing plot
b5d16b6
@wniestroj
Fix plot buttons being overlapped
4ae1e41
@wniestroj
Remove unintentional prop pass
f5ec1b5
@wniestroj
Add Ref prefix to reference plot lines; Fix plots not resize on initi…
98241df 
…al load
@wniestroj
Fix vertical scroll being visible on horizontal layout
8303c04
@wniestroj
Merge remote-tracking branch 'origin/ui-enhancements' into feedback-c…
66c3ce0 
…hanges-and-fixes

# Conflicts:
#	frontend-v2/src/features/simulation/SimulationPlotView.tsx
@wniestroj
Fix vertical scroll being visible on horizontal layout
52c7834
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2024

Quality Gate Passed Quality Gate passed for 'pkpdapp'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2024

Quality Gate Failed Quality Gate failed for 'pkpdapp-team_pkpdapp_frontend'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
3.3% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@codecov Codecov
Copy link

codecov bot commented Dec 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.70%. Comparing base (18209ee) to head (f008753).
Report is 18 commits behind head on ui-enhancements.

Additional details and impacted files 
@@               Coverage Diff                @@
##           ui-enhancements     #616   +/-   ##
================================================
  Coverage            76.70%   76.70%           
================================================
  Files                  117      117           
  Lines                 5705     5705           
================================================
  Hits                  4376     4376           
  Misses                1329     1329

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

eatyourgreens
eatyourgreens approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@eatyourgreens eatyourgreens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@wniestroj wniestroj merged commit 755f850 into ui-enhancements Dec 5, 2024
10 of 11 checks passed
@wniestroj wniestroj deleted the feedback-changes-and-fixes branch December 5, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eatyourgreens eatyourgreens eatyourgreens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wniestroj @eatyourgreens