refactor(frontend) align data upload dosing with Trial Design #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When uploading data without any dosing rows, use the project dosing protocols to determine the default dosing compartments. Previously, an uploaded subject group could only be mapped to a single dosing compartment, even if the model allowed for both IV and SC dosing
eatyourgreens
force-pushed
the
refactor-new-admin-ids
branch
from
1929b39 to
1cd29df
Compare
eatyourgreens
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## ui-enhancements #639 +/- ##
================================================
Coverage 76.70% 76.70%
================================================
Files 117 117
Lines 5705 5705
================================================
Hits 4376 4376
Misses 1329 1329 ☔ View full report in Codecov by Sentry. |
eatyourgreens
force-pushed
the
refactor-new-admin-ids
branch
from
9ceff37 to
88b1bf0
Compare
eatyourgreens
force-pushed
the
refactor-new-admin-ids
branch
2 times, most recently
from
677401f to
cdd7480
Compare
eatyourgreens
force-pushed
the
refactor-new-admin-ids
branch
5 times, most recently
from
0eb9db6 to
9ce9a10
Compare
eatyourgreens
force-pushed
the
refactor-new-admin-ids
branch
2 times, most recently
from
0897c75 to
d0abca0
Compare
eatyourgreens
force-pushed
the
refactor-new-admin-ids
branch
from
d0abca0 to
9923a6a
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When uploading data without any dosing rows, use the project dosing protocols to determine the default dosing compartments. Previously, an uploaded subject group could only be mapped to a single dosing compartment, even if the model allowed for both IV and SC dosing. With the changes here, subject groups can be dosed from each compartment linked to the model (when an uploaded CSV doesn't have any dosing rows.)
Alter the dosing check in the sidebar so that it only flags up a group if none of that group's protocols have a dose set, rather than checking if any doses are 0.