Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add administrative and county types #46

Merged
merged 6 commits into from
Feb 23, 2024
Merged

Add administrative and county types #46

merged 6 commits into from
Feb 23, 2024

Conversation

raphi
Copy link
Member

@raphi raphi commented Feb 23, 2024

  • Add default icon for administrative type
  • Add default icon for county type
  • Upgrade to latest client-js
  • Update sub display text for new types

@raphi raphi added the enhancement New feature or request label Feb 23, 2024
@raphi raphi requested a review from noclat February 23, 2024 08:28
@raphi raphi self-assigned this Feb 23, 2024
noclat
noclat requested changes Feb 23, 2024
View reviewed changes
Copy link
Member

@noclat noclat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 💪
Careful that you forgot to increment the version :)

@raphi raphi requested a review from noclat February 23, 2024 11:44
@raphi raphi merged commit 97245eb into main Feb 23, 2024
1 check passed
@raphi raphi deleted the feat/types branch February 23, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noclat noclat noclat approved these changes

Assignees

@raphi raphi

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@raphi @noclat