Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RemoteMessage Type in Notification.create #58

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

naporin0624
Copy link
Contributor

Description:

Thank you for developing the karte SDK for react-native.

Overview

This PR proposes a modification to the type of RemoteMessage that Notification.create accepts.

Details

We're utilizing version v18.3.0 of @react-native-firebase/messaging. A recent PR in @react-native-firebase/messaging, view it here, introduced changes to the RemoteMessage type. This PR aims to address and adjust to those changes:

- data?: { [key: string]: string };
+ data?: { [key: string]: string | object };

Additional Notes

  • Confirmed that yarn tsc --noEmit runs without issues.

  • Ensured that yarn test executes successfully.

  • Verified that yarn build operates correctly.

  • My knowledge in Swift and Kotlin is limited; hence, I haven't been able to verify if these type changes have any side effects in the nativeModule.

@naporin0624 naporin0624 changed the title Update RemoteMessage Type in Notification.create for react-native karte SDK Update RemoteMessage Type in Notification.create Oct 4, 2023
@SojiroNishimura
Copy link
Contributor

@naporin0624
Thank you for contributing our SDK! We have confirmed your PR and it seems fine. We are merging it and publish fixed version shortly.

@SojiroNishimura SojiroNishimura merged commit 25db007 into plaidev:master Feb 20, 2024
@naporin0624 naporin0624 deleted the fix/remote-message-type branch February 20, 2024 09:49
@naporin0624
Copy link
Contributor Author

@naporin0624

Thank you for contributing our SDK! We have confirmed your PR and it seems fine. We are merging it and publish fixed version shortly.

@SojiroNishimura thank you!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants