Update RemoteMessage
Type in Notification.create
#58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Thank you for developing the karte SDK for react-native.
Overview
This PR proposes a modification to the type of
RemoteMessage
thatNotification.create
accepts.Details
We're utilizing version v18.3.0 of
@react-native-firebase/messaging
. A recent PR in@react-native-firebase/messaging
, view it here, introduced changes to theRemoteMessage
type. This PR aims to address and adjust to those changes:Additional Notes
Confirmed that
yarn tsc --noEmit
runs without issues.Ensured that
yarn test
executes successfully.Verified that
yarn build
operates correctly.My knowledge in Swift and Kotlin is limited; hence, I haven't been able to verify if these type changes have any side effects in the nativeModule.