This repository has been archived by the owner on Jan 28, 2023. It is now read-only.
Config #567
Open
Config #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Based on a quick look at the code, this looks pretty helpful. The configuration file location has been a sort of ongoing issue for a lot of people. Let me take a closer look at it and I'll probably just merge it in. Thanks!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch moves $APP_CONFIG into an object at SiriProxy.config. It also creates a new command +genconfig+ that creates the appropriate configuration directory and copies +config.example.y+ into it.
This lays the groundwork for people to use SiriProxy as a daemonized process on *nix with its configuration file in /etc/siriproxy.d, while retaining the original usage pattern of .siriproxy in the home directory.