Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pixel_type more explicit and extended #20

Merged
merged 3 commits into from
Jun 14, 2015

Conversation

godber
Copy link
Member

@godber godber commented Jun 10, 2015

I have extended pixel_type to include more types and to be more
explicit. The handling of floats is not yet done. It is also not
yet clear to me why an assert wasn't working for me. I think the values
were equivalent, just not represented the same.

This isn't ready to be merged yet, I've just pushed it for review: @wtolson

I am still trying to figure out how to express IEEE_REAL and PC_REAL in numpy.

refs #16

I have extended pixel_type to include more types and to be more
explicit.  The handling of floats is not yet done.  It is also not
yet clear to me why an assert wasn't working for me.

refs #16
@godber
Copy link
Member Author

godber commented Jun 10, 2015

Actually, if I take the resulting img.data from the HiRISE PC_REAL example and do img.data.newbyteorder('<') it looks right.

Also, it would probably be more succinct if I used the <f4 or >i2 notation for creating these. I don't understand that notation yet, so I will have to look into it.

@godber
Copy link
Member Author

godber commented Jun 14, 2015

:( broken, shame felt, looks like I need to ensure sample_bytes is an int.

@godber
Copy link
Member Author

godber commented Jun 14, 2015

I like how this has worked out.

This notebook kind of indicates the status
http://nbviewer.ipython.org/urls/gist.githubusercontent.com/godber/2530f95e2986655ecaac/raw/Test_All.ipynb

Here are the data products in a json file:
https://gist.githubusercontent.com/godber/34a7639cfc457150f22c/raw/4d1e3745f8e68a0d7b6106cf5cd2fba4102fb074/mission_data.json

I think I understand most of the failures here:

Not sure whats up with M1166071628ME.IMG.

godber added a commit that referenced this pull request Jun 14, 2015
pixel_type more explicit and extended to support float image types
@godber godber merged commit 37ce5b6 into master Jun 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant