Fix for gxp #189 - allow matchCase in WFS Filter #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -165,7 +171,7 @@ gxp.form.FilterField = Ext.extend(Ext.form.CompositeField, { | |||
| * {OpenLayers.Filter} By default, returns a comarison filter. | |||
| */ | |||
| createDefaultFilter: function() { | |||
| return new OpenLayers.Filter.Comparison(); | |||
| return new OpenLayers.Filter.Comparison({matchCase: this.caseInsensitiveMatch}); | |||
There was a problem hiding this comment.
Shouldn't this be {matchCase: !this.caseInsensitiveMatch}) instead?
There was a problem hiding this comment.
Oops, yes indeed. Added a new commit to fix. best, Just
On 26-05-13 01:57, ahocevar wrote:
In src/script/widgets/form/FilterField.js:
@@ -165,7 +171,7 @@ gxp.form.FilterField = Ext.extend(Ext.form.CompositeField, {
* {OpenLayers.Filter} By default, returns a comarison filter.
*/
createDefaultFilter: function() {
return new OpenLayers.Filter.Comparison();return new OpenLayers.Filter.Comparison({matchCase: this.caseInsensitiveMatch});Shouldn't this be |{matchCase: !this.caseInsensitiveMatch})| instead?
—
Reply to this email directly or view it on GitHub
https://github.com/opengeo/gxp/pull/190/files#r4393548.
…issing negation
ahocevar
added a commit
that referenced
this pull request
May 26, 2013
Fix for gxp #189 - allow matchCase in WFS Filter
|
Top! Thanks Andreas. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See description in issue #189. With this fix the QueryPanel gets an extra config param 'caseInsensitiveMatch' (default false) to allow case-insensitive string matching for attribute conditions in OL ComparisonFilter's. This setting propagates to an OpenLayers WFS Filter attribute 'matchCase'.
See a working example here:
http://lib.heron-mc.org/heron/latest/examples/querybuilder