-
Notifications
You must be signed in to change notification settings - Fork 98
Add destinations api client #1175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Linting aside, do we want to target this to main-3.0-dev, since we plan on releasing 3.0 next week? Selfishly, I want carrots of new features in 3.0 and not just the stick I brought of the disruption of new OAuth mechanisms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds comprehensive support for the new Destinations API by implementing both synchronous and asynchronous client libraries, along with a complete CLI interface. The implementation enables users to create, list, update, and manage destinations for data delivery across various cloud storage providers including Amazon S3, Google Cloud Storage, Azure Blob Storage, and Oracle Cloud Storage.
Key changes include:
- Added async
DestinationsClientand syncDestinationsAPIclasses with full CRUD operations - Implemented comprehensive CLI commands for destination management with provider-specific subcommands
- Extended existing Orders and Subscriptions APIs to support destination filtering
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| planet/clients/destinations.py | New async client implementing core Destinations API operations |
| planet/sync/destinations.py | Synchronous wrapper for the destinations client |
| planet/cli/destinations.py | Complete CLI interface with create, list, update, and archive commands |
| planet/clients/orders.py | Added destination_ref filtering parameter |
| planet/clients/subscriptions.py | Added destination_ref filtering parameter |
| tests/integration/test_destinations_api.py | Integration tests covering all client operations |
| docs/cli/cli-destinations.md | Comprehensive tutorial for CLI usage |
Co-authored-by: Adrian Sonnenschein <[email protected]> Co-authored-by: Copilot <[email protected]>
Co-authored-by: Adrian Sonnenschein <[email protected]> Co-authored-by: Copilot <[email protected]>
…o charcey/destinations merge main
|
LGTM! Let's get this merged to |
Proposed Changes:
For inclusion in changelog (if applicable):
Diff of User Interface
Old behavior: N/A
New behavior:
Users can interact with the Destinations API via python client or CLI. Tests added. CLI tutorial added.
PR Checklist:
(Optional) @mentions for Notifications: