Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add key prop to fix error with multiple pdf pages #107

Merged
merged 1 commit into from
Oct 4, 2019

Conversation

cmwint
Copy link
Contributor

@cmwint cmwint commented Aug 29, 2019

This commit will fix the Missing keys on iterators issue here: #73

@pg-infosec
Copy link

Vulnerable Package: webpack-dev-server
Affected Range: < 3.1.11
Fixed Version: 3.1.11
Related CVE: CVE-2018-14732
Severity: LOW

More Information: Please consider upgrading webpack-dev-server to prevent deploying vulnerable code into production. For more information, visit: https://nvd.nist.gov/vuln/detail/CVE-2018-14732, or visit the FAQ

@pg-infosec
Copy link

Vulnerable Package: eslint
Affected Range: < 4.18.2
Fixed Version: 4.18.2
Related CVE: WS-2018-0592
Severity: MODERATE

More Information: Please consider upgrading eslint to prevent deploying vulnerable code into production. For more information, visit: eslint/eslint@f6901d0, or visit the FAQ

@cmwint
Copy link
Contributor Author

cmwint commented Sep 5, 2019

@aaronnorby @aschiopu @viktoriyavulfson is anyone available to review this and merge, please? I think it would benefit many people using this library! Thank you.

@aaronnorby
Copy link
Contributor

@cmwint I'm no longer a maintainer on this project and can't merge things - sorry

@cmwint
Copy link
Contributor Author

cmwint commented Sep 16, 2019

@aschiopu @viktoriyavulfson can someone please review this small change and approve? I appreciate your time and this package!

@viktoriyavulfson
Copy link
Contributor

@cmwint Unfortunately, I'm no longer a maintainer on this project as well.

@cmwint
Copy link
Contributor Author

cmwint commented Sep 24, 2019

@aschiopu are you still a maintainer of this project? Or is there another person I can ask, please?

@apennell
Copy link

apennell commented Oct 2, 2019

@cmwint Hey make it count for Hacktoberfest! Maybe @michaelwolo is still a maintainer?

Copy link
Contributor

@michaelwolo michaelwolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@michaelwolo michaelwolo merged commit 9f4d340 into plangrid:master Oct 4, 2019
@apennell
Copy link

apennell commented Oct 4, 2019

🙌

@akhilaudable
Copy link

It's merged on OCT 5th. I installed this library yesterday. Why I still see the error warning?

@SalmanHaider5
Copy link

Still issue is there, if anyone there to maintain it please do it first, its a really good package.

@bsell93
Copy link

bsell93 commented Apr 20, 2020

Looks like the changes were undone in
78f1581#diff-227f34f5a8fb440046daea8d13f0c149

@AIPB07
Copy link

AIPB07 commented Oct 20, 2020

@michaelwolo are you still a maintainer? Would you be able to approve a pull request to fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants