Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: dynamic imports for code-splitting #120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,14 +3,14 @@
"version": "1.1.0",
"description": "Extendable file viewer for web",
"main": "dist/index.js",
"module": "dist/index.js",
"module": "dist-es/index.js",
"repository": {
"type": "git",
"url": "git+https://github.com/plangrid/react-file-viewer.git"
},
"scripts": {
"dev": "webpack -d --watch",
"build": "webpack -p --progress",
"build": "webpack -p --progress --profile --json > stats.json",
"start": "node ./scripts/start.js",
"lint": "node_modules/.bin/eslint ./src/**/*.jsx",
"test": "node_modules/.bin/jest --env=jsdom --watch",
Expand Down Expand Up @@ -41,6 +41,7 @@
"devDependencies": {
"autoprefixer": "^7.1.0",
"babel-core": "^6.24.1",
"babel-eslint": "^10.0.3",
"babel-jest": "^20.0.3",
"babel-loader": "^7.0.0",
"babel-plugin-transform-class-properties": "^6.19.0",
Expand Down Expand Up @@ -75,9 +76,11 @@
"style-loader": "^0.17.0",
"url-loader": "^0.5.8",
"webpack": "^2.5.1",
"webpack-bundle-analyzer": "^3.6.0",
"webpack-dev-server": "^2.4.5"
},
"dependencies": {
"@loadable/component": "^5.10.3",
"comma-separated-values": "^3.6.4",
"mammoth": "1.3.6",
"pdfjs-dist": "1.8.357",
Expand Down Expand Up @@ -112,6 +115,7 @@
},
"eslintConfig": {
"extends": "airbnb",
"parser": "babel-eslint",
"plugins": [
"import"
],
Expand Down
13 changes: 0 additions & 13 deletions src/components/drivers/index.js

This file was deleted.

38 changes: 25 additions & 13 deletions src/components/file-viewer.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,23 @@ import PropTypes from 'prop-types';
import 'styles/main.scss';
import withFetching from './fetch-wrapper';

import {
CsvViewer,
DocxViewer,
VideoViewer,
XlsxViewer,
XBimViewer,
PDFViewer,
UnsupportedViewer,
PhotoViewerWrapper,
AudioViewer,
} from './drivers';
import loadable from '@loadable/component';

const CsvViewer = loadable(() => import('./drivers/csv-viewer'));
const Photo360Viewer = loadable(() => import('./drivers/photo360-viewer'));
const PDFViewer = loadable(() => import('./drivers/pdf-viewer'));
const DocxViewer = loadable(() => import('./drivers/docx-viewer'));
const VideoViewer = loadable(() => import('./drivers/video-viewer'));
const XlsxViewer = loadable(() => import('./drivers/xlsx-viewer'));
const XBimViewer = loadable(() => import('./drivers/xbim-viewer'));
const UnsupportedViewer = loadable(() =>
import('./drivers/unsupported-viewer'),
);
const PhotoViewer = loadable(() => import('./drivers/photo-viewer'));
const PhotoViewerWrapper = loadable(() =>
import('./drivers/photo-viewer-wrapper'),
);
const AudioViewer = loadable(() => import('./drivers/audio-viewer'));

class FileViewer extends Component {
constructor(props) {
Expand All @@ -38,7 +44,9 @@ class FileViewer extends Component {
return withFetching(CsvViewer, this.props);
}
case 'xlsx': {
const newProps = Object.assign({}, this.props, { responseType: 'arraybuffer' });
const newProps = Object.assign({}, this.props, {
responseType: 'arraybuffer',
});
return withFetching(XlsxViewer, newProps);
}
case 'jpg':
Expand Down Expand Up @@ -75,7 +83,11 @@ class FileViewer extends Component {
return (
<div className="pg-viewer-wrapper">
<div className="pg-viewer" id="pg-viewer">
<Driver {...this.props} width={this.state.width} height={this.state.height} />
<Driver
{...this.props}
width={this.state.width}
height={this.state.height}
/>
</div>
</div>
);
Expand Down
7 changes: 2 additions & 5 deletions webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ const config = {
amd: 'react-dom',
},
},
'@loadable/component',
],
module: {
rules: [
Expand All @@ -61,11 +62,7 @@ const config = {
ident: 'postcss',
plugins: () => [
autoprefixer({
browsers: [
'>1%',
'last 4 versions',
'not ie < 9',
],
browsers: ['>1%', 'last 4 versions', 'not ie < 9'],
}),
],
},
Expand Down