Update width and height of fileviewer continuously #123
+31
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses MutationObserver to watch changes to the container and update state accordingly. Falls back to previous behavior if MutationObserver is not supported, i.e. set size on mount only.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're using the FileViewer in a resizable div. This works well for things like PDFs, where increasing the width of the div zooms in on the PDF, but it is broken for images, which get a fixed width on mount, and is then never updated again.
This is a proposed fix that uses MutationObserver to watch changes to the container and update state accordingly.
Falls back to previous behavior if MutationObserver is not supported, i.e. set size on mount only.