Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Places render after abort #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Places render after abort #59

wants to merge 1 commit into from

Conversation

dkastl
Copy link

@dkastl dkastl commented Jan 30, 2018

When running npm start the build fails with:

ERROR in ./src/components/fetch-wrapper.jsx

/path/to/react-file-viewer/src/components/fetch-wrapper.jsx
  31:5  error  render should be placed after abort  react/sort-comp

✖ 1 problem (1 error, 0 warnings)

By changing the order as suggested the error seems to be resolved.

You mention a CLA in the contributing guidelines. However it's not clear how to submit this. I can't find any bot, that could fail to recognize it.

@CLAassistant
Copy link

CLAassistant commented Jan 30, 2018

CLA assistant check
All committers have signed the CLA.

@dkastl
Copy link
Author

dkastl commented Jan 30, 2018

OK, CLA problem was resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants