Feature/added feature image opening#27
Conversation
| @@ -1,5 +1,5 @@ | |||
| *.pyc | |||
|
|
|||
| **/.vscode/ | |||
| from felicette.utils.sys_utils import exit_cli, remove_dir | ||
| from felicette.sat_processor import process_landsat_data | ||
|
|
||
|
|
There was a problem hiding this comment.
For all formatting errors, like 'newline', 'deleted lines', is black used?
There was a problem hiding this comment.
No, I have not used black but certainly will use it improve the code formatting. Thank for feedback.
| exit_cli(rprint, "[red]Sorry, invalid response. Exiting :([/red]") | ||
|
|
||
|
|
||
| def handle_img_prompt_response(response_show_image,paths,key,message): |
There was a problem hiding this comment.
I think this function is redundant, because then we are asking twice if the user wants to go ahead with the download.
felicette/felicette/sat_downloader.py
Line 63 in df507be
| # improvement: filter by date, cloud cover here | ||
|
|
||
| search_items = search.items() | ||
| print("Date at which picture was taken : " + str(search_items[0].date)) |
There was a problem hiding this comment.
Can we save this to a .metadata file? Not just the date but if you try and print
felicette/felicette/sat_downloader.py
Line 43 in df507be
you'll see cloud cover, radiance and other factors. Please explore and suggest how the '.metadata' file will be for an image?
| # print success info | ||
| rprint("[blue]Preview image saved at:[/blue]") | ||
| print(paths["preview"]) | ||
| logging.info("preview imagery !!!") |
There was a problem hiding this comment.
Please refer to comment on handle_img_prompt_response.
2 participants
Added features :